[mrtg-developers] Re: cfgmaker reports wrong Max Speed with SNMPv2 (2.10.15)

[Larry Fahnoe]

Tobi,

I won't claim to be an expert on SNMP implementations, but after the
reading and thinking that I did when we discovered the problems with
incorrect speeds, I'm of the opinion that my approach would yield the
more "correct" value.  I based my logic on reading the IF-MIB which is
clear about how the vendors should use the objects, and thus my use of
the 2^32 threshold has that document as its basis; I'm not clear about
where the 100,000,000 threshold in your code comes from.

As you point out, the effect of your code is similar, though it could
still run into some rounding problems with higher speed interfaces.

--Larry

On Wed, Nov 24, 2004 at 07:54:45PM +0100, Tobias Oetiker wrote:
> Hi Larry,
> 
> The current (16pre1) cfgmaker contains the following code
> 
>              $value = $value * 1000000;  # highSpeed = contador * 10^6
>              if ( !$value || ($value < 100000000)) {
>                  ($if, $value) = split /:/, $ifSpeed[$i], 2;
>                  #debug('base',"Speed: $if - $value");
>              }
>              $routers->{$router}{$if}{'ifSpeed'} = $value;
> 
> so insetad of looking at speed, it looks for 'low' HiSpeed values
> ...
> 
> the effect should be similar, or do you see an advantage in your
> approach ?
> 
> cheers
> tobi

-- 
Larry Fahnoe, Fahnoe Technology Consulting, fahnoe at FahnoeTech.com
952/925-0744      Minneapolis, Minnesota       www.FahnoeTech.com 

--
Unsubscribe mailto:mrtg-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:mrtg-developers-request at list.ee.ethz.ch?subject=help
Archive     http://www.ee.ethz.ch/~slist/mrtg-developers