<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div><br>
</div>
<div>Gday folks.</div>
<div><br>
</div>
<div>I have been doing some testing of some options only in /trunk (not 1.4.8) and have noticed that some of the applications I am testing that use 'rrdtool graph' are doing things like…</div>
<div><br>
</div>
<div>AREA:inbits0#B6D14B:'eth0 In ':</div>
<div> and</div>
<div>AREA:outbits0_neg#A0A0E5::</div>
<div><br>
</div>
<div>Looking at <a href="http://oss.oetiker.ch/rrdtool/doc/rrdgraph_graph.en.html">http://oss.oetiker.ch/rrdtool/doc/rrdgraph_graph.en.html</a> I would assume this sytnax is probably incorrect</div>
<div><br>
</div>
<div>It appears from my testing 1.4.7 / 1.4.8 etc all "eat" these empty options without failing.</div>
<div><br>
</div>
<div>1.x/TRUNK appears to generate ERRORS, which cause the graphs to not be generated. </div>
<div><br>
</div>
<div>My question would be in the interests of backward compatibility is there some 'half-way' point where warnings could be generated rather than errors?</div>
<div><br>
</div>
<div>Regards,</div>
<div> Peter</div>
<div><br>
</div>
<div><br>
</div>
<div>
<div>$ diff -c src/rrd_graph_helper.c.orig src/rrd_graph_helper.c</div>
<div>*** src/rrd_graph_helper.c.orig 2013-08-05 14:21:22.126330617 +0930</div>
<div>--- src/rrd_graph_helper.c 2013-08-05 14:50:11.046181137 +0930</div>
<div>***************</div>
<div>*** 1429,1435 ****</div>
<div> /* check for unprocessed keyvalue args */</div>
<div> char *s;</div>
<div> if ((s=checkUnusedValues(&pa))) {</div>
<div>! rrd_set_error("Unused Arguments in %s: %s",pa.arg_orig,s);</div>
<div> freeParsedArguments(&pa);</div>
<div> free(s);</div>
<div> return;</div>
<div>--- 1429,1435 ----</div>
<div> /* check for unprocessed keyvalue args */</div>
<div> char *s;</div>
<div> if ((s=checkUnusedValues(&pa))) {</div>
<div>! //rrd_set_error("Unused Arguments in %s: %s",pa.arg_orig,s);</div>
<div> freeParsedArguments(&pa);</div>
<div> free(s);</div>
<div> Return;</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</body>
</html>