<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div>
<div>
<div>
<div style="color: rgb(0, 0, 0); font-family: Calibri, sans-serif; font-size: 14px; ">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri, sans-serif; font-size: 14px; ">
Reading the comments, and the edit to src/rrd_graph.c</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri, sans-serif; font-size: 14px; ">
<br>
</div>
<div>
<div><font class="Apple-style-span" face="Calibri,sans-serif"> <span class="Apple-tab-span" style="white-space: pre; ">
</span>968 <span class="Apple-tab-span" style="white-space: pre; "></span></font><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">+ // remember that we already got this one</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "> </span><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><span class="Apple-tab-span" style="white-space: pre; ">
</span></span><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">969 </span><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><span class="Apple-tab-span" style="white-space: pre; "></span></span><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">+
g_hash_table_insert(im->rrd_map,gdes_fetch_key(im->gdes[i]),GINT_TO_POINTER(i));</span></div>
</div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">I have noted when I tried to build a custom backend using rrdcached protocol that when drawing a graph it appeared to a little inefficient.</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">For example</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "> If I had a RRD with DS(s) of inOct, outOct, inErrs, outErrs and then used 'graph' to generate a single graph with all those DS's from the same RRD I would see 4 FETCH operations
via rrdcached.</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">Since the fetch does not specify the DS required, all the datasources in the RRD need to be returned. This probably isn't a problem for simple RRD files, but for example if you
have 12 metrics, and each metric has a 'cost' to 'get', and you only really need two for your graph, you need to fetch them all anyway (or in my example, you need to fetch them all, then remangle them into the appropriate structures, then return them ..)</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">My question is -- does this change to the rrd_graph data_fetch() mean that I will not see multiple fetch operations ?</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">(I guess I should just go and test it ...)</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; ">:)</span></div>
<div><span class="Apple-style-span" style="font-family: Calibri, sans-serif; "><br>
</span></div>
</div>
</div>
</div>
</body>
</html>