From l3on at ubuntu.com Sat May 19 15:24:07 2012 From: l3on at ubuntu.com (Leo Iannacone) Date: Sat, 19 May 2012 15:24:07 +0200 Subject: [mrtg-developers] Please make ifref default to name Message-ID: Dear developers, in Ubuntu we apply this patch in order to make --ifref default to name. The reason of this change is that the order of the interfaces is unreliable, while ifref=name seems to be better as default. Could you kindly consider to apply this patch ?? Thansk in advance, Leo. -- Ubuntu Member - http://launchpad.net/~l3on Home Page - http://leoiannacone.com GPG Key Id - 0xD282FC25 -------------- next part -------------- A non-text attachment was scrubbed... Name: make-ifref-default-to-name.patch Type: application/octet-stream Size: 2424 bytes Desc: not available Url : http://lists.oetiker.ch/pipermail/mrtg-developers/attachments/20120519/360e6b70/attachment.obj From s.shipway at auckland.ac.nz Sat May 19 22:27:24 2012 From: s.shipway at auckland.ac.nz (Steve Shipway) Date: Sat, 19 May 2012 20:27:24 +0000 Subject: [mrtg-developers] Please make ifref default to name In-Reply-To: References: Message-ID: <7294716191A1E142B80615ED2C633BCA0132E173@uxcn10-2.UoA.auckland.ac.nz> Can't you already do this by specifying a list of alternatives to the --ifref option? That's what we do. Steve Steve Shipway University of Auckland ITS UNIX Systems Design Lead s.shipway at auckland.ac.nz Ph: +64 9 373 7599 ext 86487 ________________________________________ From: mrtg-developers-bounces+steve=steveshipway.org at lists.oetiker.ch [mrtg-developers-bounces+steve=steveshipway.org at lists.oetiker.ch] on behalf of Leo Iannacone [l3on at ubuntu.com] Sent: Sunday, 20 May 2012 1:24 a.m. To: mrtg-developers at lists.oetiker.ch Subject: [mrtg-developers] Please make ifref default to name Dear developers, in Ubuntu we apply this patch in order to make --ifref default to name. The reason of this change is that the order of the interfaces is unreliable, while ifref=name seems to be better as default. Could you kindly consider to apply this patch ?? Thansk in advance, Leo. -- Ubuntu Member - http://launchpad.net/~l3on Home Page - http://leoiannacone.com GPG Key Id - 0xD282FC25 From tobi at oetiker.ch Wed May 23 17:34:09 2012 From: tobi at oetiker.ch (Tobias Oetiker) Date: Wed, 23 May 2012 17:34:09 +0200 (CEST) Subject: [mrtg-developers] Please make ifref default to name In-Reply-To: References: Message-ID: Hi Leo, Saturday Leo Iannacone wrote: > Dear developers, > > in Ubuntu we apply this patch in order to make --ifref default to name. > > The reason of this change is that the order of the interfaces is > unreliable, while ifref=name seems to be better as default. > > Could you kindly consider to apply this patch ?? I agree, that matching by name is a good idea if your devices support that ... BUT ... changeing the default behaviour of cfgmaker is not something that I would do lightly, especially for something that has been like this for the last 17 years ... many users have scripts running launching cfgmaker automatically and they expect it to act in a certain way ... cheers tobi -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900 From s.shipway at auckland.ac.nz Thu May 24 07:14:32 2012 From: s.shipway at auckland.ac.nz (Steve Shipway) Date: Thu, 24 May 2012 05:14:32 +0000 Subject: [mrtg-developers] Avoiding RRDTool's data normalisation for selected targets Message-ID: <7294716191A1E142B80615ED2C633BCA0133142F@uxcn10-2.UoA.auckland.ac.nz> The Data Normalisation of RRDTool has some great reasons for its existence. However, some times, we want to avoid it because it makes for counter-intuitive graphs (even if they may be technically more accurate). I suggest adding a new option, 'adjtime', which will cause all data samples to be pushed back in time to the previous interval boundary, thus making Data Normalisation a null operation. This is easy to do! Simply add 3 lines to mrtg and you're there (around line 467) : debug('base', "Create Graphics"); + if( $router->{ options }{ adjtime } ) { + $time -= ($time % $cfg{interval} ) + } if ($rcfg{'options'}{'dorelpercent'}{$router}) { You also need to add 'adjtime' to the @known_options array in the cfgcheck() function in MRTG_lib.pm . my(@known_options) = qw(growright bits noinfo absolute gauge nopercent avgpeak derive integer perhour perminute transparent dorelpercent unknaszero withzeroes noborder noarrow noi noo - nobanner nolegend logscale secondmean pngdate printrouter expscale); + nobanner nolegend logscale secondmean pngdate printrouter expscale adjtime); Now there are obvious downsides to this, not least that your data may be pushed back in time almost 5 minutes and result in inaccurate graphs. Multiple updates in a single interval would be rejected, and the potential for missing an interval entirely would increase (but the heartbeat could be raised to 610 to cope with the latter). However, anyone choosing to use the 'adjtime' option would do so at their own risk. The benefits would be that MRTG users could finally ensure that retrieved values would definitely be stored as-is, which helps when the variable is a low-valued integer Gauge. Thoughts? Steve _____ Steve Shipway ITS Unix Services Design Lead University of Auckland, New Zealand Floor 1, 58 Symonds Street, Auckland Phone: +64 (0)9 3737599 ext 86487 DDI: +64 (0)9 924 6487 Mobile: +64 (0)21 753 189 Email: s.shipway at auckland.ac.nz P Please consider the environment before printing this e-mail -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.oetiker.ch/pipermail/mrtg-developers/attachments/20120524/8f2de1bf/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6080 bytes Desc: not available Url : http://lists.oetiker.ch/pipermail/mrtg-developers/attachments/20120524/8f2de1bf/attachment-0001.bin From tobi at oetiker.ch Thu May 24 08:42:23 2012 From: tobi at oetiker.ch (Tobias Oetiker) Date: Thu, 24 May 2012 08:42:23 +0200 (CEST) Subject: [mrtg-developers] Avoiding RRDTool's data normalisation for selected targets In-Reply-To: <7294716191A1E142B80615ED2C633BCA0133142F@uxcn10-2.UoA.auckland.ac.nz> References: <7294716191A1E142B80615ED2C633BCA0133142F@uxcn10-2.UoA.auckland.ac.nz> Message-ID: Hi Steve, Today Steve Shipway wrote: > The Data Normalisation of RRDTool has some great reasons for its existence. > However, some times, we want to avoid it because it makes for > counter-intuitive graphs (even if they may be technically more accurate). > > > > I suggest adding a new option, 'adjtime', which will cause all data samples > to be pushed back in time to the previous interval boundary, thus making > Data Normalisation a null operation. > > > > This is easy to do! Simply add 3 lines to mrtg and you're there (around > line 467) : > > > > debug('base', "Create Graphics"); > > + if( $router->{ options }{ adjtime } ) { > > + $time -= ($time % $cfg{interval} ) > > + } > > if ($rcfg{'options'}{'dorelpercent'}{$router}) { > > > > You also need to add 'adjtime' to the @known_options array in the cfgcheck() > function in MRTG_lib.pm . > > > > my(@known_options) = qw(growright bits noinfo absolute gauge nopercent > avgpeak derive > > integer perhour perminute transparent dorelpercent > > unknaszero withzeroes noborder noarrow noi noo > > - nobanner nolegend logscale secondmean pngdate printrouter > expscale); > > + nobanner nolegend logscale secondmean pngdate printrouter > expscale adjtime); > > > Now there are obvious downsides to this, not least that your data may be > pushed back in time almost 5 minutes and result in inaccurate graphs. > Multiple updates in a single interval would be rejected, and the potential > for missing an interval entirely would increase (but the heartbeat could be > raised to 610 to cope with the latter). However, anyone choosing to use the > 'adjtime' option would do so at their own risk. The benefits would be that > MRTG users could finally ensure that retrieved values would definitely be > stored as-is, which helps when the variable is a low-valued integer Gauge. how about calling the option 'fiddle-with-arrival-time-of-data' ? but yes, if you think this is what we need to make users happy, by all means, send a patch (and one for the documentation too). cheers tobi > > > > Thoughts? > > > > Steve > > > > _____ > > Steve Shipway > > ITS Unix Services Design Lead > > University of Auckland, New Zealand > > Floor 1, 58 Symonds Street, Auckland > > Phone: +64 (0)9 3737599 ext 86487 > > DDI: +64 (0)9 924 6487 > > Mobile: +64 (0)21 753 189 > > Email: s.shipway at auckland.ac.nz > > P Please consider the environment before printing this e-mail > > > > > > -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900 From l3on at ubuntu.com Fri May 25 16:14:34 2012 From: l3on at ubuntu.com (Leo Iannacone) Date: Fri, 25 May 2012 16:14:34 +0200 Subject: [mrtg-developers] Please make ifref default to name In-Reply-To: References: Message-ID: On 23 May 2012 17:34, Tobias Oetiker wrote: > Hi Leo, Hi Tobias! > I agree, that matching by name is a good idea if your devices > support that ... > > BUT ... changeing the default behaviour of cfgmaker is not > something that I would do lightly, especially for something that > has been like this for the last 17 years ... many users have > scripts running launching cfgmaker automatically and they expect it > to act in a certain way ... Maybe it could make sense check in the code if "those scripts" still use old value and print a "WARNING: Deprecated" string in case, warning users about this change... and after one or two release, move option to use name... This is just a suggestion, nothing else. :) Ciao! Leo. -- Ubuntu Member - http://launchpad.net/~l3on Home Page - http://leoiannacone.com GPG Key Id - 0xD282FC25 From tobi at oetiker.ch Fri May 25 17:27:10 2012 From: tobi at oetiker.ch (Tobias Oetiker) Date: Fri, 25 May 2012 17:27:10 +0200 (CEST) Subject: [mrtg-developers] Please make ifref default to name In-Reply-To: References: Message-ID: Hi Leo, Today Leo Iannacone wrote: > On 23 May 2012 17:34, Tobias Oetiker wrote: > > Hi Leo, > > Hi Tobias! > > > I agree, that matching by name is a good idea if your devices > > support that ... > > > > BUT ... changeing the default behaviour of cfgmaker is not > > something that I would do lightly, especially for something that > > has been like this for the last 17 years ... many users have > > scripts running launching cfgmaker automatically and they expect it > > to act in a certain way ... > > Maybe it could make sense check in the code if "those scripts" still > use old value and print a "WARNING: Deprecated" string in case, > warning users about this change... > > and after one or two release, move option to use name... > > This is just a suggestion, nothing else. :) you have no idea how slow users are in adopting new things. ubuntu with its rather brisk mode of change is 'hip and cool' but presents many shops with severe problems as new releases come along dropping well loved modes of operation ... cheers tobi > > Ciao! > > Leo. > > -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900 From s.shipway at auckland.ac.nz Sat May 26 02:45:07 2012 From: s.shipway at auckland.ac.nz (Steve Shipway) Date: Sat, 26 May 2012 00:45:07 +0000 Subject: [mrtg-developers] Please make ifref default to name In-Reply-To: References: , Message-ID: <7294716191A1E142B80615ED2C633BCA01336D12@uxcn10-2.UoA.auckland.ac.nz> Why not just call cfgmaker with the approprtae ifref option chain -- eg, cfgmaker --ifref=ip,descr,name This will make it use name is ip is not defined, and so on. Then cfgmaker can still kep its own internal default but you've overridden it with your own. This way, no need to change the cfgmaker application and confuse people... Steve Steve Shipway University of Auckland ITS UNIX Systems Design Lead s.shipway at auckland.ac.nz Ph: +64 9 373 7599 ext 86487