[rrd-developers] Re: 18:00 yesterday - is this timespec OK?

[Tobias Oetiker]

Today Pavel Mores wrote:

>
>
> Hello,
>
> I'm building a custom monitoring system based on the wonderful rrdtool.
> However, I've been unable to figure out how to use the "yesterday"
> day specification. I think that "18:00 yesterday" should be valid
> according to the syntax described in parsedate.c . "18:00" looks like a
> valid TIME-OF-DAY-SPEC, "yesterday" is included in DAY-SPEC-2 list of
> options and together they form a valid TIME-REFERENCE.
>
> Still, the parser refuses it ("ERROR: start time: unparsable trailing
> text: '...yesterday'"). Looking at parsetime() it seems to me that
> there's a bug in the "case NUMBER:" block. tod() parses the "18:00" part
> and prefetches the "yesterday" token. However, if the prefetched token
> is not NUMBER (which it is not here) parsing essentially ends here (from
> now on the parser looks for offset spec only) so no wonder that
> "yesterday" comes out as "unparsable trailing text".
>
> Is this just my stupidity or is it really a bug?

the parsetime code is badly broken. A working and correct version
or also patches for the bugs are greatly appreciated ... I have
never been bothered enough to fix it myself ... (shame on me)

cheers
tobi
>
>         pvl
>
>
> --
> Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
> Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
> Archive     http://www.ee.ethz.ch/~slist/rrd-developers
> WebAdmin    http://www.ee.ethz.ch/~slist/lsg2.cgi
>
>

-- 
 ______    __   _
/_  __/_  / /  (_) Oetiker, ETZ J97, ETH, 8092 Zurich, Switzerland
 / // _ \/ _ \/ / phoneto:+41(0)1-632-5286  faxto:+41(0)1-632-1517
/_/ \.__/_.__/_/ oetiker at ee.ethz.ch http://google.com/search?q=tobi


--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://www.ee.ethz.ch/~slist/rrd-developers
WebAdmin    http://www.ee.ethz.ch/~slist/lsg2.cgi