[rrd-developers] Problem with current version of rrd_rpncalc.c

[Alex van den Bogaerdt]

Hi,

rrd_rpncalc.c uses DEF_NAM_FMT but this is never defined.

This is introduced in version 1.10 of the file:
    Index: rrd_rpncalc.c
    ===================================================================
    RCS file: /usr/cvs/rrdtool/program/src/rrd_rpncalc.c,v
    retrieving revision 1.9
    retrieving revision 1.10
    diff -r1.9 -r1.10
    274c274
    <         else if (sscanf(expr, #VVV "(%[a-z0-9]s)",vname) == 1) { \
    ---
    >         else if (sscanf(expr, #VVV "(" DEF_NAM_FMT ")",vname) == 1) { \

The simple solution would be to add the define to the file:
    #define DEF_NAM_FMT "%29[_A-Za-z0-9]"

Of course, that is not a good solution.  Another solution could be to
include rrd_graph.h (where DEF_NAM_FMT currently is defined).

However, the best solution may be to either move this define to rrd_tool.h
or to rrd_rpncalc.h, or to create a new header file altogether
(which then can be included in the suitable place).

Comments?
-- 
   __________________________________________________________________
 / alex at slot.hollandcasino.nl                  alex at ergens.op.het.net \
| work                                                         private |
| My employer is capable of speaking therefore I speak only for myself |
+----------------------------------------------------------------------+
| Technical questions sent directly to me will be nuked. Use the list. | 
+----------------------------------------------------------------------+
| http://faq.mrtg.org/                                                 |
| http://rrdtool.eu.org  --> tutorial                                  |
+----------------------------------------------------------------------+

--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://www.ee.ethz.ch/~slist/rrd-developers
WebAdmin    http://www.ee.ethz.ch/~slist/lsg2.cgi