[rrd-developers] Re: Fix for non-functional python bindings

[Jarod Wilson]

Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2006-08-02 at 10:32 -0400, Jarod Wilson wrote:
> On Wed, 2006-08-02 at 09:33 -0400, Haroon Rafique wrote:
> > This is the exact same problem as mentioned in the list earlier in thes=
e 2=20
> > messages:
> >=20
> > http://lists.ee.ethz.ch/rrd-users/msg11466.html
> > http://lists.ee.ethz.ch/rrd-users/msg11511.html
> >=20
> > And, BTW, Mihai's patch looks like it reverts the changeset 839:
> > http://people.ee.ethz.ch/~oetiker/webtools/rrdtool-trac/changeset/839
> >=20
> > The commit message on the changeset mentions Duncan Webb.
> >=20
> >   * python uses the name of the module for loding, so this should bette=
r=20
> >     match up -- Duncan Webb duncan dwebb
> >=20
> > Can Duncan perhaps jump into the discussion, please?
>
> Indeed, I'd like to understand exactly what changeset 839 was supposed
> to be fixing, and why the 'fix' apparently wasn't tested... For now, I'm
> applying a patch to the Fedora Extras packages to simply revert it.

Took a look at 839 again, and talked with Mihai a bit. Based on that
discussion, the patch we're now applying now also (re)alters the
ErrorObject line, but sets it to:
=20
  ErrorObject =3D PyErr_NewException("rrdtool.error", NULL, NULL);

Neither rrdtoolmodule.error or _rrdtool.error looked correct. Updated
patch attached.

--=20
Jarod Wilson
jwilson at redhat.com



-- Attached file removed by Ecartis and put at URL below --
-- Type: text/x-patch
-- Size: 1k (1270 bytes)
-- URL : http://lists.ee.ethz.ch/p/02-rrdtool-1.2.15-initrrdtool.patch



-- Attached file removed by Ecartis and put at URL below --
-- Type: application/pgp-signature
-- Desc: This is a digitally signed message part
-- Size: 190 bytes
-- URL : http://lists.ee.ethz.ch/p/04-signature.asc


--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://lists.ee.ethz.ch/rrd-developers
WebAdmin    http://lists.ee.ethz.ch/lsg2.cgi