[rrd-developers] Re: Patch to rrd_dump.c to allow output to a filename as well as stdout

[Nicola Worthington]

On Sun, 8 Jan 2006, Peter Stamfest wrote:

> +    fprintf(out_file, "</rrd>\n");
>      rrd_free(&rrd);
>      fclose(in_file);
> +    if (out_file)
> +    {
> +      fclose(out_file);
> +    }
>      return(0);
>  }
>
> Shouldn't that check at least be (out_file != stdout)? Otherwise you'll end up
> closing stdout.
>
> peter

Yes, you're quite right. It was in fact meant to be exactly that.

Should I send again,.. who picks up patches for possible inclusion?

Nicola


-- 
Nicola Worthington
http://perlgirl.org.uk
nicolaw at arwen.tfb.net

--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://lists.ee.ethz.ch/rrd-developers
WebAdmin    http://lists.ee.ethz.ch/lsg2.cgi