[rrd-developers] Re: graph step=n not working in 1.2.13

[Tobias Oetiker]

Hi Niels,

you are right ... line 742 is not necessary ... since in r291 there
was also this line added

@@ -2584,7 +2580,7 @@
     }


-    im->gdes[im->gdes_c-1].step=def_step;
+    im->gdes[im->gdes_c-1].step=im->step;
     im->gdes[im->gdes_c-1].stack=0;
     im->gdes[im->gdes_c-1].debug=0;
     im->gdes[im->gdes_c-1].start=im->start;

this suffices ...

thanks
tobi


Tuesday Niels Endres wrote:

> Hi,
>
>    When I try the following using rrdtool 1.2.13:
>
> 	rrdtool graph test.png
> 		DEF:val=test.rrd:data:AVERAGE
> 		DEF:avg=test.rrd:data:AVERAGE:step=3600
> 		LINE:val#ff0000
> 		LINE:avg#00ff00
>
>    the avg line is the same as the val line (instead of being a lower
> resolution average, as the default step is 600).
>
>    I've traced this back to the "im->gdes[i].step = im->step;" operation
> on line 742 of rrd_graph.c.  Removing this line fixes this problem.  I
> can't work out why it's there in the first place, so don't know if this
> would break something else.
>
> Cheers,
> Niels
>
>

-- 
ETH Zurich
Tobias Oetiker, IT Support Group D-ITET (ISG.EE)
ETL F24.2, Physikstrasse 3, 8092 Zurich, Switzerland
Phone +41 44 63 25286,  http://people.ee.ethz.ch/oetiker/

--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://lists.ee.ethz.ch/rrd-developers
WebAdmin    http://lists.ee.ethz.ch/lsg2.cgi