[rrd-developers] [PATCH,RFC] optional mmap based file I/O

[Tobias Oetiker]

Hi Bernhard,

thanks for the fix ...

it is in ...

what versions of pango/cairo does RHEL5 provide ?

in what manner do the bindings fail ?

maybe it is fixable, if not I will add
a check to the configure.ac so that we know

cheers
tobi



Today Bernhard Fischer wrote:

> Hi,
>
> below is a bugfix for update.
>
> We maintain our write- and read- position in the rrd_file_t struct. One
> hunk of old code was in #ifndef HAVE_MMAP which caused our internal
> rrd_file->pos not to be updated when we had to wrap the rra_ptr.
>
> The attached patch fixes this. It also makes sure that we do not do
> several superfluous write()s to areas that are already uptodate for the
> mmap case (since there, we already operate on the underlying file
> directly resp. the one copy the kernel holds for us. In this case, we do
> not need to re-write the already uptodate data).
>
> Tobi, please apply.
>
> - fix maintaining our file-pos when we have to wrap the rra_ptr in
>   update().
> - no need to update the header-data a second time for the mmap case.
>
> PS: The new pangoCairo renderer is disfunctional on RHEL5 due to Redhat
> only shipping an older version of pango/cairo. Just a heads-up.
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten
http://it.oetiker.ch tobi at oetiker.ch ++41 62 213 9902