[rrd-developers] [PATCH,RFC] optional mmap based file I/O

Bernhard Fischer rep.dot.nop at gmail.com
Thu May 24 20:39:07 CEST 2007


On Thu, May 24, 2007 at 05:46:12PM +0200, Bernhard Fischer wrote:
>Updates:
>- fix typo in rrd_fetch where rrd_read result was checked against an
>  incorrect size.
>- in rrd_fetch, drop rrd_head_size in favour of rrd_file->header_len
>- in rrd_fetch, make the message "post fetch" unambiguous (now past vs.
>  post).
>- change usage of param rdwr of rrd_open: allow for RRD_READONLY,
>  RRD_READWRITE, RRD_CREAT, RRD_READAHEAD; adjust callers accordingly:
>  + rrd_resize needs CREAT
>  + rrd_dump may want READAHEAD
>- implement FD based I/O in rrd_open, rrd_read, rrd_write, rrd_seek.
>- in rrd_update, unify write_RRA_row().
>- sort | uniq the -T in .indent.pro (info_t was duplicated)
>- add stub of an option to use O_DIRECT to the configury
>- in Makefile.am, simplify the "indent" invocation of find:
>  My find may not support "-o" resp. "-or" nor braces.
>  Using -name "*.[ch]" works everywhere, AFAIK.
>
>Please apply.

Incremental patch ontop of the one above.

- add some more rrd_sterror calls to failure paths.
- make rrdtool updatev work like 1.2.23 (i.e. multiple values are still
  broken, but at least updating a single value works; see
  http://oss.oetiker.ch/rrdtool-trac/ticket/8)
- indent touched files.

Please apply.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrdtool-1.2.99-svn.20070524-1726-incremental.01.diff
Type: text/x-diff
Size: 5832 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20070524/f4ea0ab2/attachment.bin 


More information about the rrd-developers mailing list