[rrd-developers] make 1.3 trunk build on OS/X

[Ian Holsman]

Hi Tobi + friends,

I just pulled the latest trunk onto my macbook pro (Darwin Aeaea.local 
8.10.3 Darwin Kernel Version 8.10.3: Wed Jun 27 23:29:36 PDT 2007; 
root:xnu-792.23.3~1/RELEASE_I386 i386 i386)


and I ran into several issues with the code.

1. compile issue in rrd_getopt

Index: src/rrd_getopt.c
===================================================================
--- src/rrd_getopt.c    (revision 1194)
+++ src/rrd_getopt.c    (working copy)
@@ -190,7 +190,7 @@
    of the value of `ordering'.  In the case of RETURN_IN_ORDER, only
    `--' can cause `getopt' to return -1 with `optind' != ARGC.  */
 
-static const enum {
+static /*const*/ enum {
     REQUIRE_ORDER, PERMUTE, RETURN_IN_ORDER
 } ordering;

2. the madvise call wasn't being properly detected. it should have put
#undef _POSIX_C_SOURCE
in rrd_config.h, as madvise and mincore are only defined if the 
following is true

#ifndef _POSIX_C_SOURCE
int     madvise(void *, size_t, int);
int     mincore(const void *, size_t, char *);
int     minherit(void *, size_t, int);
#endif

I couldn't get it to build properly until I put the #includes in 
rrd_open.c directly

3. fdatasync is not defined



regards
Ian