[rrd-developers] rrd_fetch seek issue

[Tobias Oetiker]

Hi Daniel,

Today Daniel.Pocock at barclayscapital.com wrote:

>
> > note that there is code to wrap the rra_pointer back to the
> > start of the archive once it ventures over the end of the archive ...
> >
> >             if (rra_pointer >= (signed)
> > rrd.rra_def[chosen_rra].row_cnt) {
> >                 rra_pointer -= rrd.rra_def[chosen_rra].row_cnt;
>
>
>
> It doesn't get that far - the problem occurs in the first seek, where
> r1689 corrected the other issue

ah because of the +1 ... :-)

so does

Index: rrd_fetch.c
===================================================================
--- rrd_fetch.c (revision 1703)
+++ rrd_fetch.c (working copy)
@@ -390,6 +390,8 @@
         else
             rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1 + start_offset;

+        rra_pointer = rra_pointer % (signed) rrd.rra_def[chosen_rra].row_cnt;
+
         if (rrd_seek(rrd_file, (rra_base + (rra_pointer * (*ds_cnt)
                                         * sizeof(rrd_value_t))),
                  SEEK_SET) != 0) {


help ?

tobi

> _______________________________________________
>
> This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
> _______________________________________________
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900