[rrd-developers] it exposes too much ...

[Tobias Oetiker]

Florian,

> Hi Tobi,
>
> On Tue, Jun 10, 2008 at 04:17:47PM +0200, Tobias Oetiker wrote:
> > if you can send the patch in the next few hours we will manage to cram
> > it into 1.3.0 still ...
>
> ugh, that's a rough deadline ;) I made it though, but only gave this a
> quick test:
> -- 8< --
>  octo at leeloo:/tmp/rrdtest $ gcc -I/tmp/rrdtool/include -L/tmp/rrdtool/lib -o foo foo.c -lrrd
>  foo.c: In function `main':
>  foo.c:5: error: `rrd_t' undeclared (first use in this function)
>  foo.c:5: error: (Each undeclared identifier is reported only once
>  foo.c:5: error: for each function it appears in.)
>  foo.c:5: error: expected `;' before `buffer'
>  foo.c:7: error: `buffer' undeclared (first use in this function)
>  octo at leeloo:/tmp/rrdtest $ gcc -I/tmp/rrdtool/include -L/tmp/rrdtool/lib -DRRD_EXPORT_DEPRECATED -o foo foo.c -lrrd
>  foo.c: In function `main':
>  foo.c:7: warning: `rrd_init' is deprecated (declared at /tmp/rrdtool/include/rrd.h:330)
>  foo.c:9: warning: `rrd_lock' is deprecated (declared at /tmp/rrdtool/include/rrd.h:352)
> -- >8 --
>
> Everything I changed is hidden within the #if, normal applications
> should not notice the change at all. I didn't test RRDTool itself with
> `-Werror' since there are a couple of unrelated warnings which would
> terminate the build..
>
> Let me know what you think. I have a date at 19:30 (GMT+1) and can fix
> stuff till then ;)

I like it ... very neat thanks. So finally there is a somewhat
defined API for rrdtool ... this is very nice. I have integrated
the patch and so fahr things seem to work for me.

cheers
tobi

>
> Regards,
> -octo
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten
http://it.oetiker.ch tobi at oetiker.ch ++41 62 213 9902