[rrd-developers] rrd_fetch seek issue

[Tobias Oetiker]

Hi Daniel,

(I have not yet looked at the code).

I just tried to reproduce the problem here and it did not work.

I guess you are hitting some sort of a corner case ... can you
create a little demo script ...

cheers
tobi


Today
Daniel.Pocock at barclayscapital.com wrote:

>
>
>
> If an RRD hasn't been updated recently, and I try to invoke rrd_fetch
> for a more recent time interval, it tries to seek on the file anyway - I
> only discovered this issue when the RRD hadn't updated for over 2 hours,
> and it tried to seek beyond the end of the file, causing this "seek
> error in RRA" from rrd_fetch.c:
>
>     /* fill the gap at the start if needs be */
>
>     if (start_offset <= 0)
>         rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1;
>     else
>         rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1 +
> start_offset;
>
>     if (rrd_seek(rrd_file, (rra_base + (rra_pointer * (*ds_cnt)
>                                         * sizeof(rrd_value_t))),
>                  SEEK_SET) != 0) {
>         rrd_set_error("seek error in RRA");
>         goto err_free_data;
>
>
> This suggests more range checking is needed on both the start and finish
> times and how they relate to the last_update time for the RRD.
>
> Regards,
>
> Daniel
> _______________________________________________
>
> This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered off
 ic
>  e at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
> _______________________________________________
>
> _______________________________________________
> rrd-developers mailing list
> rrd-developers at lists.oetiker.ch
> https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900