[rrd-developers] [patch] rrdcached init script and spec file

[Sebastian Harl]

Hi Daniel,

> diff -ur --unidirectional-new-file rrdtool-1.3.99908093000.orig/etc/rrdcached-default rrdtool-1.3.99908093000/etc/rrdcached-default
> --- rrdtool-1.3.99908093000.orig/etc/rrdcached-default	1970-01-01 01:00:00.000000000 +0100
> +++ rrdtool-1.3.99908093000/etc/rrdcached-default	2008-09-30 17:00:54.000000000 +0100
[...]
> +SOCKPERMS=0666

> diff -ur --unidirectional-new-file rrdtool-1.3.99908093000.orig/etc/rrdcached-init rrdtool-1.3.99908093000/etc/rrdcached-init
> --- rrdtool-1.3.99908093000.orig/etc/rrdcached-init	1970-01-01 01:00:00.000000000 +0100
> +++ rrdtool-1.3.99908093000/etc/rrdcached-init	2008-10-01 11:05:10.000000000 +0100
[...]
> +      [ $RETVAL -eq 0 ] && chmod $SOCKPERMS "${SOCKFILE}"

Is there any specific reason why you default to a world read- and
write-able socket? I don't think this is a good idea.

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20081001/2f2239bd/attachment.bin