[rrd-developers] src/rrd_open.c: Check arguments in `rrd_dontneed'.

Florian Forster rrdtool at nospam.verplant.org
Tue Oct 7 15:27:29 CEST 2008


From: Florian Forster <octo at verplant.org>

Daniel Pocock reported that the argument may be NULL in low-diskspace
situations, so check for that here to prevent a segmentation fault.
---
 src/rrd_open.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/rrd_open.c b/src/rrd_open.c
index 2796506..f262413 100644
--- a/src/rrd_open.c
+++ b/src/rrd_open.c
@@ -364,6 +364,13 @@ void rrd_dontneed(
     unsigned long i;
     ssize_t   _page_size = sysconf(_SC_PAGESIZE);
 
+    if (rrd_file == NULL) {
+#if defined DEBUG && DEBUG
+	    fprintf (stderr, "rrd_dontneed: Argument 'rrd_file' is NULL.\n");
+#endif
+	    return;
+    }
+
 #if defined DEBUG && DEBUG > 1
     mincore_print(rrd_file, "before");
 #endif
-- 
1.5.6.3



More information about the rrd-developers mailing list