[rrd-developers] [PATCH] connection_thread_main: avoid double calls to close_connection

kevin brintnall kbrint at rufus.net
Wed Oct 8 06:02:16 CEST 2008


---
 src/rrd_daemon.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c
index 9c8847d..36d418b 100644
--- a/src/rrd_daemon.c
+++ b/src/rrd_daemon.c
@@ -1844,23 +1844,18 @@ static void *connection_thread_main (void *args) /* {{{ */
     else if (status < 0) /* error */
     {
       status = errno;
-      if (status == EINTR)
-        continue;
-      RRDD_LOG (LOG_ERR, "connection_thread_main: poll(2) failed.");
+      if (status != EINTR)
+        RRDD_LOG (LOG_ERR, "connection_thread_main: poll(2) failed.");
       continue;
     }
 
     if ((pollfd.revents & POLLHUP) != 0) /* normal shutdown */
-    {
-      close_connection(sock);
       break;
-    }
     else if ((pollfd.revents & (POLLIN | POLLPRI)) == 0)
     {
       RRDD_LOG (LOG_WARNING, "connection_thread_main: "
           "poll(2) returned something unexpected: %#04hx",
           pollfd.revents);
-      close_connection(sock);
       break;
     }
 
-- 
1.6.0.2



More information about the rrd-developers mailing list