[rrd-developers] [patch] rrd_create via rrd_open.c

Daniel.Pocock at barclayscapital.com Daniel.Pocock at barclayscapital.com
Tue Oct 14 12:29:29 CEST 2008


> > --- src/rrd_create.c	(revision 1598)
> > +++ src/rrd_create.c	(working copy)
> [...]
> > -#if defined(_WIN32) && !defined(__CYGWIN__) && 
> !defined(__CYGWIN32__)
> > -    flags |= O_BINARY;
> > -#endif
> Why did you remove that? Afaik, that's required on windows - 
> it has just been added in r1423.

All low level code (such as setting the flags for the C library calls)
should be in rrd_open.c - the code in rrd_create.c was therefore
redundant.  The flag still gets set in rrd_open.


This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.

More information about the rrd-developers mailing list