[rrd-developers] rrd_open.c: mremap not portable, /trunk build broken

Daniel.Pocock at barclayscapital.com Daniel.Pocock at barclayscapital.com
Wed Oct 15 12:55:26 CEST 2008


> oops thanks for picking this up ... I have reverted r1601 and r1606
> 
> @daniel, please resubmit without mremap dependency ...
> 

The https method for SVN works for me, thanks for providing that

Now using munmap followed by a new call to mmap

This has a few consequences:

- The effects of any previous madvise calls will be lost, it should only
be an issue for rrd_create though as nothing else should append the rrd
file.

- Any pointers made from rrd_file_t.file_start will become invalid - I
couldn't find any other code using this pointer, however, I will submit
another patch later that buries the pointer and file descriptor so that
it is less likely that someone uses them outside rrd_open.c

Regards,

Daniel

_______________________________________________

This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
_______________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrdcreate.patch1-munmap
Type: application/octet-stream
Size: 10769 bytes
Desc: rrdcreate.patch1-munmap
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20081015/65962f78/attachment-0001.obj 


More information about the rrd-developers mailing list