[rrd-developers] [PATCH] rrdc_flush_if_daemon should not clobber error message

kevin brintnall kbrint at rufus.net
Thu Oct 16 08:30:47 CEST 2008


In almost all cases where rrdc_flush can fail, it will leave a more
descriptive error message anyway..  better not overwrite it.
---
 src/rrd_client.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/src/rrd_client.c b/src/rrd_client.c
index 5583bfe..5e22a98 100644
--- a/src/rrd_client.c
+++ b/src/rrd_client.c
@@ -615,14 +615,7 @@ int rrdc_flush_if_daemon (const char *opt_daemon, const char *filename) /* {{{ *
   rrdc_connect(opt_daemon);
 
   if (rrdc_is_connected(opt_daemon))
-  {
     status = rrdc_flush (filename);
-    if (status != 0)
-    {
-      rrd_set_error ("rrdc_flush (%s) failed with status %i.",
-                     filename, status);
-    }
-  } /* if (rrdc_is_connected(..)) */
 
   return status;
 } /* }}} int rrdc_flush_if_daemon */
-- 
1.6.0.2



More information about the rrd-developers mailing list