[rrd-developers] [PATCH] rrdc_flush_if_daemon should not clobber error message

[Tobias Oetiker]

Today kevin brintnall wrote:

> In almost all cases where rrdc_flush can fail, it will leave a more
> descriptive error message anyway..  better not overwrite it.

ok ... Sebastians idea does look sensible ... or are you sure that
all bases are covered ...

cheers
tobi

> ---
>  src/rrd_client.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/src/rrd_client.c b/src/rrd_client.c
> index 5583bfe..5e22a98 100644
> --- a/src/rrd_client.c
> +++ b/src/rrd_client.c
> @@ -615,14 +615,7 @@ int rrdc_flush_if_daemon (const char *opt_daemon, const char *filename) /* {{{ *
>    rrdc_connect(opt_daemon);
>
>    if (rrdc_is_connected(opt_daemon))
> -  {
>      status = rrdc_flush (filename);
> -    if (status != 0)
> -    {
> -      rrd_set_error ("rrdc_flush (%s) failed with status %i.",
> -                     filename, status);
> -    }
> -  } /* if (rrdc_is_connected(..)) */
>
>    return status;
>  } /* }}} int rrdc_flush_if_daemon */
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900