[rrd-developers] [PATCH] generalisation of rrd_open API

[Tobias Oetiker]

Hi Daniel,

I think the best would be if you started writing documentation for
the functions you are implementing / planning as well as some general notes
on the design ideas.

To become realy useful, the abstraction may have to be pushed even
further ... keep in minde that as we go to a new cross platform
data format, the on disk structures will change, I would like for
that new abstraction to work with this.

cheers
tobi



Yesterday Daniel.Pocock at barclayscapital.com wrote:

>
>
>
> I've started generalising the rrd_open API
>
> The madvise stuff has come out, but it will go back in.  There are a
> couple of options:
> - pass the header size (which is already known) to
> rrd_file->vfs->open_impl, and call madvise once for the whole region
> - add an madvise function to rrd_vfs_t
>
> Also, the use of #ifndef HAVE_MMAP in rrd_update.c is something I would
> like to remove, only the code in rrd_open.c should have any knowledge of
> the underlying storage.  Maybe we need a function such as
> rrd_file->vfs->is_mmap() to make the decision at run-time instead of
> compile-time.
>
> This is not ready to commit (although it does seem to run), I am just
> putting it up for discussion.
>
> Regards,
>
> Daniel
>
> _______________________________________________
>
> This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
> _______________________________________________
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900