[rrd-developers] [PATCH] noify row patch and rrd_file.pvt patch

Tobias Oetiker tobi at oetiker.ch
Mon Oct 20 13:46:20 CEST 2008


Today Daniel.Pocock at barclayscapital.com wrote:

>
> > > rrd_notify_row patch:
> > >
> > > - Delegate choice of starting row for newly created RRD
> > files to the
> > > rrd_open.c API.
> > > - Introduce the rrd_notify_row() function so that an implementation
> > > can choose to align the rows of new RRDs with existing
> > RRDs, if desirable.
> > > - Maintain the existing behaviour (random starting row) by default.
> > >
> > > rrd_open_pvt patch:
> > >
> > > - encapsulate fd and mmap related variables within a private data
> > > structure
> > > - rrd_file_t keeps a pointer to the private data structure of type
> > > void*, so that other block storage implementations can store their
> > > internal data with rrd_file_t
> >
> > both are applied
>
>
> The rrd_notify_row patch doesn't appear to be committed... I've attached
> it again for you.  It gives some warnings about line numbers when
> applied to r1621, but these can be safely ignored:

oops ... fixed
tobi

>
> $ patch -p0 < ~/01-rrd_notify_row.patch
> patching file src/rrd_create.c
> patching file src/rrd_update.c
> patching file src/rrd.h
> Hunk #1 succeeded at 412 (offset 39 lines).
> patching file src/rrd_open.c
> Hunk #1 succeeded at 80 with fuzz 2 (offset 26 lines).
> Hunk #2 succeeded at 703 (offset 15 lines).
>
>
> _______________________________________________
>
> This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
> _______________________________________________
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900


More information about the rrd-developers mailing list