[rrd-developers] [PATCH] create the pid file before forking, so we can complain to stderr

Sebastian Harl sh at tokkee.org
Fri Sep 26 10:43:43 CEST 2008


Hi Kevin,

On Fri, Sep 26, 2008 at 02:23:53AM +0000, kevin brintnall wrote:
> -    RRDD_LOG (LOG_ERR, "write_pidfile: Opening `%s' failed.", file);
> +    RRDD_LOG (LOG_ERR, "write_pidfile: fopen() failed.");

Any reason why you've changed that to a less informative message? If you
want consistency with the other error messages I'd rather change the
others to be more verbose about what went wrong.

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20080926/f37390e4/attachment-0001.bin 


More information about the rrd-developers mailing list