[rrd-developers] [PATCH] [BUG] flush_file: when deciding whether to flush, check values_num, not values

Tobias Oetiker tobi at oetiker.ch
Sun Sep 28 21:22:23 CEST 2008


Kevin,

this does not apply either.

cheers
tobi
Friday kevin brintnall wrote:

> Even though the old way works (due to NULL == 0), it's NOT right.
>
> Sorry for the noise.  I should have caught this earlier.
>
> ---
>  src/rrd_daemon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c
> index 36d090c..f111637 100644
> --- a/src/rrd_daemon.c
> +++ b/src/rrd_daemon.c
> @@ -745,7 +745,7 @@ static int flush_file (const char *filename) /* {{{ */
>      return (ENOENT);
>    }
>
> -  if (ci->values > 0)
> +  if (ci->values_num > 0)
>    {
>      /* Enqueue at head */
>      enqueue_cache_item (ci, HEAD);
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900



More information about the rrd-developers mailing list