[rrd-developers] [PATCH] Suggestion for API extension (rrd_dump)

[Benny Baumann]

Hi Tobias,

Am 08.08.2009 11:49, schrieb Tobias Oetiker:
> Hi Benny,
>
> the patch seems sane to me from looking at your code ... I will be
> glad to include it if you can provide a version that applies to
>
>   svn://svn.oetiker.ch/rrdtool/trunk/program
>   
As the version available in the public download directory and the SVN
differ quite a bit, I had some work on merging in my changes, thus you
might notice some differences between the old and the new API extension
patch. In particular I chose to rename the API function from
rrd_dump_opt_cb_r to rrd_dump_cb_r. I furthermore hope I didn't miss any
changes made in the SVN when I merged the files.
> also you should add a section to doc/librrd.pod explaining this new
> access method ...
>   
The API documentation explains the usage of this interface using the
internally used rrd_dump_opt_cb_fileout callback which should, because
of its simplicity, be a well-enough example.
> cheers
> tobi
>   
IDK if the rrd_dump_opt_r function should be exported too (and not only
used internally wrapped by rrd_dump and rrd_dump_r).?

Anyway: The working patch, based on revision 1886 is attached. If there
are any questions left, feel free to contact me.

Regards,
BenBE.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrd_dump_cb_r.patch
Type: text/x-diff
Size: 34215 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20090809/3906b31b/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20090809/3906b31b/attachment-0003.bin