[rrd-developers] [PATCH] graph --border

Sebastian Harl sh at tokkee.org
Wed Aug 19 16:55:19 CEST 2009


Hi,

On Wed, Aug 19, 2009 at 04:32:20PM +0200, Bernhard Reutner-Fischer wrote:
> --- src/rrd_tool.c	(revision 1896)
> +++ src/rrd_tool.c	(working copy)
[…]
> +/* didn't look closely, nor think.. but did you mean ') && !(' below? */
>      if (!(im->extra_flags & NOLEGEND) & !(im->extra_flags & ONLY_GRAPH)) {
[…]

I'm pretty sure that this is supposed to be '&&'. However, in this
particular case, it does not make any difference. The NOT operator (!)
has to return either 0 or 1 (according to C99 that is). In that case
'&&' is equivalent to '&'. Anyway, I still think that should be fixed
;-)

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20090819/9b6b4a48/attachment.pgp 


More information about the rrd-developers mailing list