[rrd-developers] Possible race conditions / data loss in rrdcached?
sh at tokkee.org
Tue Jul 14 14:18:14 CEST 2009
On Tue, Jul 14, 2009 at 07:01:38AM -0500, kevin brintnall wrote:
> > > Anyway, this should be easy to fix. See the patch, I'll send in a
> > > minute. Beware, though, that I do not have a RRDCacheD setup, so the
> > > patch is mostly untested - it compiles though ;-)
> > Your patch doesn't address the problem. I will email another shortly.
> I reviewed it again... your patch does address the problem nicely.
> I sent an updated one which removes the ci->flags mod (not necessary)
Yep, I know that it's currently unnecessary. However, imho, removing any
flags is better from a semantical point of view, since the object has
just been allocated and thus no flags apply yet. This _might_ avoid
problems in the future if free_cache_item() does care about some of the
flags in the future (which is not very unlikely imho).
> matches the if()-style up with the rest of the code.
Sure, go ahead :-)
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20090714/151f877f/attachment.bin
More information about the rrd-developers