[rrd-developers] [PATCH] rrd_client: Do not rewrite path names when accessing remote daemons.
sh at tokkee.org
Wed Oct 7 12:51:04 CEST 2009
On Wed, Oct 07, 2009 at 11:36:42AM +0200, Florian Forster wrote:
> Wouldn't it be *much* simpler to simply let the user chose what to do?
> I. e. forbid absolute paths by default and only if the
> option is given accept absolute paths.
Just to specify that further: This switch would define the behavior of
*any* connection to the daemon, no matter if local or remote. Absolute
path names would, obviously, always be relative to the root directory -
no matter what kind of base directory has been specified (the daemon
*always* uses a base directory - if not specified on the command line it
defaults to /tmp currently, so treating that differently if this has
been specified on the command line does not make sense). It should be
noted that absolute path names may still be rejected if they point
outside the base directory and -B has been specified on the command
line. Thinking about that again, the -B option basically already
provides the suggested behavior, so there should not be the need for
another option. Relative path names would always be treated relative to
the base directory.
Anyway, I've just noticed that this is in fact a bit orthogonal to the
*client* side path name translation, we've talked about previously. I've
just talked to Florian about that on IRC and we both agreed that some-
thing like that should in fact not be done in the library at all but
rather (if it really needs to be there) belongs into the rrdtool binary.
The purpose of the library is to provide an abstraction and API over the
network protocol. Any further usability features, especially those that
are highly controversial like this one, should be left out of it. So, if
that feature should be preserved, it should be implemented in rrdtool
and possibly be configurable through a command line option - again, this
should be disabled by default imho.
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20091007/fe89fc14/attachment-0001.pgp
More information about the rrd-developers