[rrd-developers] [PATCH] RRDCacheD: FETCH command: Remove call to "rrd_parsetime".

Tobias Oetiker tobi at oetiker.ch
Thu Apr 29 07:44:48 CEST 2010


Hi Florian,

Yesterday Florian Forster wrote:

> From: Florian Forster <octo at noris.net>
>
> "rrd_parsetime" uses (many) global variables and is thus not
> thread-safe. Using it in the FETCH command reproducably segfaults the
> caching daemon.
>
> This replacement will only work with "simple" integers, i. e. times
> specified as "1272470594" (sometime on April 28th) or "-3600" (one hour
> ago).
>
> A more thorough fix would be to rewrite "rrd_parsetime" in a thread-safe
> manner, but unfortunately I don't have the time right now.

yep!
cheers
tobi

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900



More information about the rrd-developers mailing list