[rrd-developers] Bug#573299: rrdtool: ERROR: unknown option 'M'

[Sebastian Harl]

tags 573299 + patch pending
thanks

Hi,

(This is a follow-up to Debian bug #573299 -- see
<http://bugs.debian.org/573299> for details.)

On Wed, Mar 10, 2010 at 02:17:20PM +0100, Ralf Hildebrandt wrote:
> /usr/bin/rrdtool graph '/usr/share/serverstats/graph/23e14748c7e0282b6acbbc1bd26e1fea.png' -t
> 'CPU usage' -s '-86400' -a 'PNG' -w '500' -h '150' -u '100' -l '0' -M -z
[...]
> results in:
> 
> ERROR: unknown option 'M'
> 
> Yet the man page says:
> 
> # rrdtool help graph |grep M
> [-M|--alt-autoscale-max]
> [COMMENT:text]

Thanks for reporting this!

The attached, trivial patch fixes this issue.

Also, since getopt_long() was told to return `m' to indicate the
``--zoom'' option, I presume that `-m' was supposed to be supported as
well. Thus, I've added support for that as well and documented that in
the rrdgraph(1) manpage.

Tobi, is that fine for you?

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bts573299_cl_options.patch
Type: text/x-diff
Size: 1209 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20100321/f7eb145f/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20100321/f7eb145f/attachment.pgp