[rrd-developers] RRDTool patch addressing concerns about r2130

Steve Shipway s.shipway at auckland.ac.nz
Mon Oct 4 06:12:21 CEST 2010

Attached is a diff addressing the issues reported for patch r2130.

Specifically, this deals with:

1.       Remove opt_no_overwrite and the rrd_create_set_no_overwrite function as they are ugly.  Make opt_no_overwrite a local var.

2.       Add 'no_overwrite' param to the rrd_create_r and rename as rrd_create_r2, add rrd_create_r  that calls rrd_create_r2 with a 0 for the no_overwrite function, preserving the API parameter format but allowing an extended arg list that can be used by rrd_create and rrd_handle_request_create

3.       Add -O option to rrdcached command line to force no-overwrite on any creates

4.       Add -O option on create via rrdcached to optionally add no-overwrite (cannot remove it is it was previously set at start)

5.       Fix rrd_handle_request_last to check the queue instead of forcing a flush.  Remove -no-flush option from LAST command since it is now no longer relevant as we're querying the cache chain

6.       Fix ulong/unsigned long issue for compilation under windows

7.       Change rrd_handle_request_create to only accept timestamp parameters, not at-syntax, in order to be threadsafe.  This is no  loss since the rrd_client already pre-parses any at-style syntax

8.       Reinstate missing free() in rrd_info.c and rrd_last.c

This fixes the long-standing issue of the global opt_no_overwrite variable, so a bit of a bonus there.


Steve Shipway
ITS Unix Services Design Lead
University of Auckland, New Zealand
Floor 1, 58 Symonds Street, Auckland
Phone: +64 (0)9 3737599 ext 86487
DDI: +64 (0)9 924 6487
Mobile: +64 (0)21 753 189
Email: s.shipway at auckland.ac.nz<mailto:s.shipway at auckland.ac.nz>
P Please consider the environment before printing this e-mail

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20101004/b51c8155/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrd-fixes.diff
Type: application/octet-stream
Size: 5344 bytes
Desc: rrd-fixes.diff
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20101004/b51c8155/attachment.obj 

More information about the rrd-developers mailing list