[rrd-developers] rrdcached: path sanitizer

Kiss Gabor (Bitman) kissg at ssg.ki.iif.hu
Thu Dec 6 06:31:47 CET 2012


> >        realpath() expands all symbolic links and resolves references  to
> >  /./,

> This is going to cause a LOT of stat() calls: O(commands * average dir
> depth)
> 
> I see your point, but it's probably better to do trivial string
> manipulations that don't hit the filesystem.
> The whole point of rrdcached is to defer and collate I/O.

You are absolutely right. Originally I wanted a simple character
copy function but suddenly I found realpath() and I was too happy
to think over what happens to symlinks. Sorry for the noise.

Gabor



More information about the rrd-developers mailing list