[rrd-developers] Bug#663505: rrdcached segfaults - not checked realpath and strdup

[Tobias Oetiker]

Hi Sebastian,

thanks ... patch is applied as r2285

cheers
tobi


Today Sebastian Harl wrote:

> forwarded 663505 rrd-developers at lists.oetiker.ch
> thanks
>
> Hi,
>
> forwarding to the RRDtool developers mailing list. Summary for the
> reference: RRDCacheD segfaults at startup if the journal directory does
> not exist.
>
> See <http://bugs.debian.org/663505> for details.
>
> On Mon, Mar 12, 2012 at 04:03:18AM +0100, Witold Baryluk wrote:
> > problem is in incorrect error handling.
> >
> > Attached patch adds realpath and strdup error handling for journal dir
> > option.
>
> Thanks for reporting this and providing a patch!
>
> A similar fix has already been applied to upstream SVN, see r2153. Tobi,
> could that patch be merged to 1.4 as well?
>
> > Why journal dir was not created in first place, is different story
> > (probably bug in postinst script)
>
> In fact, the postinst script does not take care of that at all. Imho,
> RRDCacheD should do that (and did it, in the past iirc).
>
> Imho, realpath() should in fact be called after rrd_mkdir_p(). I don't
> think there is a need for having an absolute / canonicalized pathname
> when creating the directory.
>
> Thoughts?
>
> Cheers,
> Sebastian
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900