[rrd-developers] [PATCH] rrd_client.c issues

Svante Signell svante.signell at gmail.com
Mon Aug 19 21:03:13 CEST 2013

On Mon, 2013-08-19 at 20:54 +0200, Tobias Oetiker wrote:
> Hi Svante,
> Today Svante Signell wrote:
> > >
> > > better choose a new function name and whoever is using it knows
> > > that they have to free the data they get from the call.
> >
> > What about the new version, here get_path is defined differently
> > depending on whether POSIX.1-2008 is supported or not by #if-ing on
> > _POSIX_VERSION (see man realpath). However, I can use a different name
> > for the alloced version compared to the constant version.
> I just realice that get_path is a static function, so there is no
> problem 'fixing/changeing' it since it is not visible from the
> outside.
> sorry for the confusion

Should the code be conditional or not, what do you prefer?
BTW: get_abs_path in rrd_daemon.c is also static.

More information about the rrd-developers mailing list