[rrd-developers] [rrd] rrdtool 1.5.1 released

[Bruce Morgan]

Still a few bugs I'm afraid.

Using RRDtool version 1.4.7 I get a graph with the following command
(actually I use RRDs but no matter):
rrdtool graph /tmp/vic-crlt-pe1:25900_day.png --start -24h --end 1429773557
--width 820 --height 350 --title "vic-crlt-pe1 xe-0/0/3.201"  -a PNG
DEF:687_xe_0_0_3_201=/srv/netdata/scu/data/vic-crlt-pe1/rrd/687/687-xe-0_0_3_201.rrd:ds0:AVERAGE
DEF:o687_xe_0_0_3_201=/srv/netdata/scu/data/vic-crlt-pe1/rrd/687/687-xe-0_0_3_201.rrd:ds1:AVERAGE
CDEF:687_xe_0_0_3_201b=687_xe_0_0_3_201,8,*
CDEF:o687_xe_0_0_3_201b=o687_xe_0_0_3_201,-8,*
CDEF:o687_xe_0_0_3_201bits=o687_xe_0_0_3_201,8,*
CDEF:d_687_xe_0_0_3_201b=687_xe_0_0_3_201b,o687_xe_0_0_3_201b,+
LINE:687_xe_0_0_3_201b#000000: HRULE:0#000000:
LINE:o687_xe_0_0_3_201b#000000:
VDEF:687_xe_0_0_3_20195=687_xe_0_0_3_201b,95,PERCENT
VDEF:687_xe_0_0_3_201av=687_xe_0_0_3_201b,AVERAGE
VDEF:687_xe_0_0_3_201max=687_xe_0_0_3_201b,MAXIMUM
VDEF:687_xe_0_0_3_201c=687_xe_0_0_3_201b,LAST
VDEF:o687_xe_0_0_3_20195=o687_xe_0_0_3_201bits,95,PERCENT
VDEF:o687_xe_0_0_3_201av=o687_xe_0_0_3_201bits,AVERAGE
VDEF:o687_xe_0_0_3_201max=o687_xe_0_0_3_201bits,MAXIMUM
VDEF:o687_xe_0_0_3_201c=o687_xe_0_0_3_201bits,LAST
PRINT:687_xe_0_0_3_20195:%6.3lf PRINT:o687_xe_0_0_3_20195:%6.3lf
PRINT:687_xe_0_0_3_201av:%6.3lf PRINT:o687_xe_0_0_3_201av:%6.3lf
PRINT:687_xe_0_0_3_201max:%6.3lf PRINT:o687_xe_0_0_3_201max:%6.3lf
PRINT:687_xe_0_0_3_201c:%6.3lf PRINT:o687_xe_0_0_3_201c:%6.3lf
901x420
  -nan
  -nan
  -nan
  -nan
  -nan
  -nan
  -nan
  -nan

However in 1.5 I get the following:
rrdtool graph /tmp/vic-crlt-pe1:25900_day.png --start -24h --end 1429773557
--width 820 --height 350 --title "vic-crlt-pe1 xe-0/0/3.201"  -a PNG
DEF:687_xe_0_0_3_201=/srv/netdata/scu/data/vic-crlt-pe1/rrd/687/687-xe-0_0_3_201.rrd:ds0:AVERAGE
DEF:o687_xe_0_0_3_201=/srv/netdata/scu/data/vic-crlt-pe1/rrd/687/687-xe-0_0_3_201.rrd:ds1:AVERAGE
CDEF:687_xe_0_0_3_201b=687_xe_0_0_3_201,8,*
CDEF:o687_xe_0_0_3_201b=o687_xe_0_0_3_201,-8,*
CDEF:o687_xe_0_0_3_201bits=o687_xe_0_0_3_201,8,*
CDEF:d_687_xe_0_0_3_201b=687_xe_0_0_3_201b,o687_xe_0_0_3_201b,+
LINE:687_xe_0_0_3_201b#000000: HRULE:0#000000:
LINE:o687_xe_0_0_3_201b#000000:
VDEF:687_xe_0_0_3_20195=687_xe_0_0_3_201b,95,PERCENT
VDEF:687_xe_0_0_3_201av=687_xe_0_0_3_201b,AVERAGE
VDEF:687_xe_0_0_3_201max=687_xe_0_0_3_201b,MAXIMUM
VDEF:687_xe_0_0_3_201c=687_xe_0_0_3_201b,LAST
VDEF:o687_xe_0_0_3_20195=o687_xe_0_0_3_201bits,95,PERCENT
VDEF:o687_xe_0_0_3_201av=o687_xe_0_0_3_201bits,AVERAGE
VDEF:o687_xe_0_0_3_201max=o687_xe_0_0_3_201bits,MAXIMUM
VDEF:o687_xe_0_0_3_201c=o687_xe_0_0_3_201bits,LAST
PRINT:687_xe_0_0_3_20195:%6.3lf PRINT:o687_xe_0_0_3_20195:%6.3lf
PRINT:687_xe_0_0_3_201av:%6.3lf PRINT:o687_xe_0_0_3_201av:%6.3lf
PRINT:687_xe_0_0_3_201max:%6.3lf PRINT:o687_xe_0_0_3_201max:%6.3lf
PRINT:687_xe_0_0_3_201c:%6.3lf PRINT:o687_xe_0_0_3_201c:%6.3lf
Unable to create graph: Not a valid vname: o687_xe_0_0_3_201bit in line
o687_xe_0_0_3_201bits,95,PERCENT

So the error message shows a truncated vname

In rrd_graph_helper.c:

   strncpy(gdp->ds_nam,gdp->rpn,DS_NAM_SIZE);
    *c=',';
    /* trying to find the vidx for that name */
    gdp->vidx = find_var(im, gdp->ds_nam);
    if (gdp->vidx<0) { *c=',';
      rrd_set_error("Not a valid vname: %s in line %s", gdp->ds_nam,
gdp->rpn);
      return 1;}

So it seems that the lookahead is getting the comma earlier than it should.
Anyone able to sort this?

Many Thanks

Bruce




--
View this message in context: http://rrd-mailinglists.937164.n2.nabble.com/rrd-rrdtool-1-5-1-released-tp7582902p7582907.html
Sent from the RRDtool Developers Mailinglist mailing list archive at Nabble.com.