[rrd-developers] Re: [PATCH] rrdtool 1.0.47 breakage for older perls

[Tobias Oetiker]

Hi Blair,

thanks for the patches ... the Makefile things are easy to add, not
so sure about the bits with the missing functions ... I am not
realy a porting guru as far as old perl versions are concerned ...

but I will be glad to add any fix you find

tobi

Yesterday Blair Zajac wrote:


[...]
> Here's a patch to fix the problem:
>
> % diff -ru ../rrdtool-1.0.47-orig .
> diff -ru ../rrdtool-1.0.47-orig/perl-shared/Makefile.PL.in ./perl-shared/Makefile.PL.in
> --- ../rrdtool-1.0.47-orig/perl-shared/Makefile.PL.in   2004-04-03 06:33:13.000000000 -0800
> +++ ./perl-shared/Makefile.PL.in        2004-04-05 11:28:15.000000000 -0700
> @@ -11,7 +11,7 @@
>      'VERSION_FROM' => '@top_srcdir@/perl-shared/RRDs.pm', # finds $VERSION
>      'DEFINE'      => "-DPERLPATCHLEVEL=$Config{PATCHLEVEL}",
>      'INC'          => '-I at top_srcdir@ -I at top_srcdir@/src -I at top_srcdir@/gd1.3',
> -    'CCFLAGS'      => '-DHAVE_CONFIG_H',
> +    'CCFLAGS'      => "$Config{ccflags} -DHAVE_CONFIG_H",
>      # where to look for the necessary libraries
>      # Perl will figure out which one is valid
>      'depend'      => {'RRDs.c' => "@top_srcdir@/src/.libs/librrd_private.a"},
>
> The second issue is that the new rrd_times() function in RRDs.xs uses
> newSVuv:
>
> +               PUSHs(sv_2mortal(newSVuv(start_tmp)));
> +               PUSHs(sv_2mortal(newSVuv(end_tmp)));
>
> which gets an unresolved link error when make test is run.  Greping
> through various perl versions, it appears that newSVuv was only added
> in Perl 5.6.x and later.
>
> Is there anything this can be safely changed to to work with older
> Perls?
>
> Best,
> Blair
>
>

-- 
 ______    __   _
/_  __/_  / /  (_) Oetiker @ ISG.EE, ETZ J97, ETH, CH-8092 Zurich
 / // _ \/ _ \/ /  System Manager, Time Lord, Coder, Designer, Coach
/_/ \.__/_.__/_/   http://people.ee.ethz.ch/~oetiker   +41(0)1-632-5286

--
Unsubscribe mailto:rrd-developers-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:rrd-developers-request at list.ee.ethz.ch?subject=help
Archive     http://www.ee.ethz.ch/~slist/rrd-developers
WebAdmin    http://www.ee.ethz.ch/~slist/lsg2.cgi