[rrd-developers] [PATCH,RFC] optional mmap based file I/O

Bernhard Fischer rep.dot.nop at gmail.com
Fri Jun 1 18:47:28 CEST 2007

On Fri, Jun 01, 2007 at 05:38:38PM +0200, Bernhard Fischer wrote:
>On Fri, Jun 01, 2007 at 05:17:33PM +0200, Bernhard Fischer wrote:
>>On Fri, Jun 01, 2007 at 11:10:36AM +0200, Tobias Oetiker wrote:
>>>> PS: I shall look at resize now..
>>- implement resize, growing part. truncation is to be done.
>>Please apply.
>oh, and the FD-based growing path was not yet tested at all, fyi.

Attached is a full patch against current trunk that implements resize
GROW. Please disregard the abovementioned previous patch and apply this
instead. This patch includes the DNAN portion mentioned below. Both mmap
and FD based GROW works again now.

>>The second patch is a question to you:
>>If i do this, then i seem to get a wrong RRD created where i'd have
>>hoped that i could get away with pre-DNAN-ing the values beforehand.
>>The binary diff looks like this (hope my mail client doesn't mangle this
>>too badly):
>It turns out that i was comparing an already resized HWPREDICT (thus the
>rows did mismatch), so disregard this (non-)issue, please.
>The only difference is that we now fill in DNAN on any resize, which is
>IMO fine.
>I have to look if we preset DNANs on updates (or perhaps you would know
>I will look at shrink during the weekend, if time permits.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrdtool-1.2.99-svn.20070601-1840.diff
Type: text/x-diff
Size: 7086 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20070601/663831c8/attachment-0001.bin 

More information about the rrd-developers mailing list