[rrd-developers] [PATCH,RFC] optional mmap based file I/O

[Bernhard Fischer]

Hi,

Currently, we do Input and Output with FILE*.

I'm attaching an RFC to add mmap I/O along file descriptor based
I/O (not FILE*, but int FD).

This incarnation lacks an impl for FD based I/O of rrd_open(), so only
the mmap-case will work for now. I was planning to fix this shortcoming
ASAP.

What do you think?



Statistics: patch is just below 70k

$ svn diff | diffstat -up0
 src/rrd_dump.c        |   24 +---
 src/rrd_fetch.c       |   52 ++++----
 src/rrd_resize.c      |   96 ++++++++--------
 src/rrd_lastupdate.c  |    8 -
 src/rrd_tune.c        |   51 ++++----
 src/rrd_restore.c     |    6 -
 src/rrd_first.c       |   21 +--
 src/rrd_info.c        |    8 -
 src/unused.h          |    7 -
 src/rrd_last.c        |    9 -
 src/rrd_thread_safe.c |    2 
 src/rrd_hw.c          |   64 +++++-----
 src/rrd_update.c      |  208 ++++++++++++++++------------------
 src/rrd_tool.h        |    9 +
 src/rrd_hw.h          |    6 -
 src/rrd.h             |   13 ++
 src/rrd_open.c        |  300 ++++++++++++++++++++++++++++++++++++--------------
 src/rrd_stat.c        |   17 +-
 src/Makefile.am       |   12 +-
 19 files changed, 536 insertions(+), 377 deletions(-)

c0ffdd59ce44b7af34258442b082485d rrdtool-1.2.23-svn-mmap.20070522-1406.diff

PS:
I've "tested" one manual invocation each of 'last', 'dump', 'fetch', and
they looked like they produce reasonable output, fwiw.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrdtool-1.2.23-svn-mmap.20070522-1406.diff
Type: text/x-diff
Size: 72007 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20070522/9db0bf7a/attachment-0001.bin