[rrd-developers] [PATCH,RFC] optional mmap based file I/O

Bernhard Fischer rep.dot.nop at gmail.com
Wed May 23 18:32:16 CEST 2007

On Tue, May 22, 2007 at 10:50:54PM +0200, Bernhard Fischer wrote:
>Currently, we do Input and Output with FILE*.
>I'm attaching an RFC to add mmap I/O along file descriptor based
>I/O (not FILE*, but int FD).
>This incarnation lacks an impl for FD based I/O of rrd_open(), so only
>the mmap-case will work for now. I was planning to fix this shortcoming

updated patch attached.
Just configury changes since the last patch:

- move config dependent includes from src/rrd_tool.h to rrd_config.h
- improve config check for isfinite/finite to take broken isfinite impls
  into account; Prefer the C99 isfinite over the BSD finite.
- improve config check for --enable-mmap; bail if it was requested but
  mmap is unavailable; improve checks for madvise to take unavailable
  madvise into account and to use posix_madvise in this case
- -std=gnu99 is a little bit dangerous since it potentially allows for
  code that is not strictly C99 compatible. Currently no such code
  exists in rrdtool, but better use -std=c99 to prevent changes that
  violate C99.

I still see implicit decls of chroot and (from rrd_graph.c) implicit
decls of localtime_r and tzset, fwiw.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrdtool-1.2.23-svn-mmap.20070523-1820.diff.bz2
Type: application/octet-stream
Size: 17183 bytes
Desc: not available
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20070523/ab0a9551/attachment-0001.obj 

More information about the rrd-developers mailing list