[rrd-developers] [PATCH] rrdcached free all allocations

[Daniel.Pocock at barclayscapital.com]

> rrdcached now frees all of its resources correctly.  This 
> facilitates memory debugging.  g_tree now knows how to free 
> the nodes when it removes them.
>

Thanks for this, I will be looking at the issue again early next week.

The issue that I had the other day was not a leak (as I confirmed when
finally able to run valgrind), it was caused by a backlog of updates -
in this condition, rrdcached just keeps growing until an out of memory
error stops it.

The root cause of the backlog of updates was that my RRAs weren't
aligned on cur_row, due to an issue in my own code.  Now that I've
aligned them, IO levels come down to normal levels, and there is no
backlog.

Although it's not an immediate issue, do you think that rrdcached should
do anything to manage a backlog?  Some possibilities might include:

- logging warning messages,
- dropping updates,
- refusing to accept updates/connections, so that the application will
know there is a problem

_______________________________________________

This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
_______________________________________________