[rrd-developers] [PATCH] rrdcached free all allocations

[kevin brintnall]

On Fri, Nov 07, 2008 at 04:22:53PM -0000, Daniel.Pocock at barclayscapital.com wrote:
> > rrdcached now frees all of its resources correctly.  This 
> > facilitates memory debugging.  g_tree now knows how to free 
> > the nodes when it removes them.
> >
> 
> Thanks for this, I will be looking at the issue again early next week.

FYI you might still notice 3 small leaks with glib.  It's slice allocator
doesn't free() the last slice.  This page has more info:

  http://live.gnome.org/Valgrind

> Although it's not an immediate issue, do you think that rrdcached should
> do anything to manage a backlog?  Some possibilities might include:
> 
> - logging warning messages,
> - dropping updates,
> - refusing to accept updates/connections, so that the application will
> know there is a problem

We could watch the count of queued values (or the size of value strings)
and start enqueueing updates when we reach some limit.  However, we'll
still reach a limit any time we're accepting values at a rate higher than
we can write.

-- 
 kevin brintnall =~ /kbrint at rufus.net/