[rrd-developers] rrd_open.c: mremap not portable, /trunk buildbroken

kevin brintnall kbrint at rufus.net
Wed Oct 15 19:15:39 CEST 2008


On Wed, Oct 15, 2008 at 05:44:14PM +0100, Daniel.Pocock at barclayscapital.com wrote:
> > I think a better approach would be to determine the length of 
> > the file in advance and just create/mmap it once.  I already 
> > wrote the code that determines the size of the data portion 
> > (it's in rrd_open):
> >
> 
> You are right, but I didn't want to be so strict with my implementation.
> 
> It may be better to just use normal writes when a new file is created -
> would you have any problem with that?

How would it differ from the original implementation?

-- 
 kevin brintnall =~ /kbrint at rufus.net/



More information about the rrd-developers mailing list