[rrd-developers] rrd_open.c: mremap not portable, /trunk buildbroken

[Daniel Pocock]

kevin brintnall wrote:
> On Wed, Oct 15, 2008 at 05:44:14PM +0100, Daniel.Pocock at barclayscapital.com wrote:
>   
>>> I think a better approach would be to determine the length of 
>>> the file in advance and just create/mmap it once.  I already 
>>> wrote the code that determines the size of the data portion 
>>> (it's in rrd_open):
>>>
>>>       
>> You are right, but I didn't want to be so strict with my implementation.
>>
>> It may be better to just use normal writes when a new file is created -
>> would you have any problem with that?
>>     
>
> How would it differ from the original implementation?
>   
The writes would be done within rrd_write, instead of directly from 
rrd_create.c