[rrd-developers] [PATCH] rrd_open.c: mremap not portable, /trunk buildbroken

[Daniel.Pocock at barclayscapital.com]

> 
> kevins aproach does sound pretty neat to me though, after all 
> the code is only for writing rrd files and with rrd files we 
> always know in advance how big they will be ... this is sort 
> of a core property of the format.
>


Ok, file size is now set shortly after open and can't be changed:

- rrd_open() calculates file size for new files and calls mmap once for
the whole file

- rrd_resize() cleaned up, no longer passing a size through the cookie
argument

- rrd_init(&my_rrd) must be called before rrd_open() - if people are
calling rrd_open directly from application code, this might be
troublesome.  Alternative solutions: creating an additional function,
rrd_open_create(), or adding an extra argument to rrd_open() for setting
the file size

- my rrd_lock() patch changes no actual code (just moves it to another
file) and does not depend on the other patches, so it can be applied
first

Regards,

Daniel

_______________________________________________

This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
_______________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-rrd_open.patch
Type: application/octet-stream
Size: 16398 bytes
Desc: 02-rrd_open.patch
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20081016/8aacceba/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-rrd_lock.patch
Type: application/octet-stream
Size: 2286 bytes
Desc: 01-rrd_lock.patch
Url : http://lists.oetiker.ch/pipermail/rrd-developers/attachments/20081016/8aacceba/attachment-0003.obj