[rrd-developers] rrd_open.c: mremap not portable, /trunk buildbroken

[Tobias Oetiker]

Yesterday Daniel.Pocock at barclayscapital.com wrote:

>
>
> > I think a better approach would be to determine the length of
> > the file in advance and just create/mmap it once.  I already
> > wrote the code that determines the size of the data portion
> > (it's in rrd_open):
> >
>
> You are right, but I didn't want to be so strict with my implementation.
>
> It may be better to just use normal writes when a new file is created -
> would you have any problem with that?

you remember my initial warning, right :-) ...

kevins aproach does sound pretty neat to me though, after all the
code is only for writing rrd files and with rrd files we always
know in advance how big they will be ... this is sort of a core
property of the format.

cheers
tobi

> _______________________________________________
>
> This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any securities, investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Barclays. Any views or opinions presented are solely those of the author and do not necessarily represent those of Barclays. This e-mail is subject to terms available at the following link: www.barcap.com/emaildisclaimer. By messaging with Barclays you consent to the foregoing.  Barclays Capital is the investment banking division of Barclays Bank PLC, a company registered in England (number 1026167) with its registered office at 1 Churchill Place, London, E14 5HP.  This email may relate to or be sent from other members of the Barclays Group.
> _______________________________________________
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900