[rrd-developers] Discuss regarding Ticket 263
tobi at oetiker.ch
Tue May 25 08:06:27 CEST 2010
well I guess at the heart of the problem is that we are allowing
'raw' strftime here and thus make rrdtool input system dependent
which is not good anyway ... grmpf.
so I guess you patch is about as good as we can get :-(
Yesterday Jean-Edouard Babin wrote:
> On Thu, May 20, 2010 at 8:33 AM, Tobias Oetiker <tobi at oetiker.ch> wrote:
> >> I called fct1 time_clean. I tried to catch as much formatter as
> >> possible but of course as strftime() formatter's are not the same
> >> depending of OS my code can't handle this very well...
> > hmmm, I wonder if strftime itself could somehow be queried to help ... the
> > list of characters you handle there seems awfully long to me ...
> I've check how I could use strftime but did not find...
> Characters I handle are characters handled by strftime on most linux
> system (SVr4, C89, C89 + Single Unix Specification, Olson's timezone
> package and glibc extension)
> I think handling more characters is better than less. There is, I
> guess, fewer probability that someone tried to display a raw %P (it's
> a GNU extension) than someone trying to display 'am' or 'pm' on GNU
> But I could restrict the character set to SVr4, C89, C89.
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900
More information about the rrd-developers