[rrd-developers] RFC: [PATCH] Portability by avoiding PATH_MAX

[Tobias Oetiker]

Today Svante Signell wrote:

> On Wed, 2014-05-07 at 08:14 +0200, Tobias Oetiker wrote:
> > Hi Svante,
> >
> > I merged a few debian patches the other day ... was this not your
> > pull request ?
>
> Thanks to the Debian patches now upstream. The other question is about
> how to properly test the PATH_MAX changes in rrdclient and rrddaemon,
> see below.
>
> > > > I did run tests/alltest and tests/tune1,tune2. All tests were OK.
> > > > Anything else to try to find out if the patches are OK? Anything I can
> > > > apply with valgrind, the tests are all shell scripts. Of course set -x
> > > > etc, will work.

just send a pull request ... there is no other magic at my disposal
atm.

you could try to add explicit tests that fail without the patch and
work with the patch ...

cheers
tobi
>
>
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
www.oetiker.ch tobi at oetiker.ch +41 62 775 9902