[rrd-developers] RFC: [PATCH] Portability by avoiding PATH_MAX

Svante Signell svante.signell at gmail.com
Wed May 7 09:04:50 CEST 2014

On Wed, 2014-05-07 at 08:36 +0200, Tobias Oetiker wrote:
> Today Svante Signell wrote:

> > > > > I did run tests/alltest and tests/tune1,tune2. All tests were OK.
> > > > > Anything else to try to find out if the patches are OK? Anything I can
> > > > > apply with valgrind, the tests are all shell scripts. Of course set -x
> > > > > etc, will work.
> just send a pull request ... there is no other magic at my disposal
> atm.

How to create a pull request? I have created a branch, but the patches
are not yet committed to that branch.

> you could try to add explicit tests that fail without the patch and
> work with the patch ...

Well, the PATH_MAX patches affect all architectures, but without them
rrdtool FTBFS for Hurd. For other architectures, like Linux, the code
should work the same. With the patches memory is allocated on the heap,
without on the stack. There should be no memory leaks in either case.

More information about the rrd-developers mailing list